Avoid direct strdup of values returned by rexmpp_xml_find_attr_val

Better to check those to not be NULL first.

1 files changed, 5 insertions, 1 deletions

diff --git a/src/rexmpp_roster.c b/src/rexmpp_roster.c
index db09ff0..6bc05fc 100644
--- a/src/rexmpp_roster.c
+++ b/src/rexmpp_roster.c
@@ -91,7 +91,11 @@ void rexmpp_roster_set (rexmpp_t *s, rexmpp_xml_t *query) {
   if (s->roster_ver != NULL) {
     free(s->roster_ver);
   }
-  s->roster_ver = strdup(rexmpp_xml_find_attr_val(query, "ver"));
+  const char *roster_ver = rexmpp_xml_find_attr_val(query, "ver");
+  s->roster_ver = NULL;
+  if (roster_ver != NULL) {
+    s->roster_ver = strdup(roster_ver);
+  }
   s->roster_items = rexmpp_xml_clone_list(query->alt.elem.children);
   if (s->roster_modify_cb != NULL) {
     rexmpp_xml_t *item;